MSVC does not actually support ubsan. There is a long-standing ticket requesting this: https://developercommunity.visualstudio.com/t/add-support-for-ubsan/840750 There are no known compilers that currently accept the `/fsanitize=undefined` spelling. clang-cl accepts `-fsanitize...`, same as regular clang. Also passes no-sanitizer-recover so that tests actually fail. Fix various ubsan-detected errors, including: * win: fix req-inl.h ubsan failure Don't use CONTAINING_RECORD macro from WinSDK, as it doesn't use the right trick which avoids member access on null pointer. Fixes: ``` src/win/req-inl.h:86:10: runtime error: member access within null pointer of type 'uv_req_t' (aka 'struct uv_req_s') SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior D:/a/libuv/libuv/src/win/req-inl.h:86:10 ``` * test: fix ubsan failure on udp_ref3 Don't call functions through different function type. Fixes: ``` src/win/udp.c:537:5: runtime error: call to function req_cb through pointer to incorrect function type 'void (*)(struct uv_udp_send_s *, int)' test\test-ref.c:66: note: req_cb defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/win/udp.c:537:5 in ``` * win: fix process-stdio.c ubsan failure When accessing HANDLEs within the stdio buffer, use memcpy / memset in order to respect alignment. Fixes: ``` src/win/process-stdio.c:197:5: runtime error: store to misaligned address 0x0230ee72d107 for type 'HANDLE' (aka 'void *'), which requires 8 byte alignment 0x0230ee72d107: note: pointer points here 00 00 cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd fd fd fd fd ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/win/process-stdio.c:197:5 in ``` * win: fix getaddrinfo.c ubsan failure Reworks buffer alignment handling to respect requirements. Fixes: ``` src/win/getaddrinfo.c:157:23: runtime error: member access within misaligned address 0x0290e4c6a17c for type 'struct addrinfo', which requires 8 byte alignment 0x0290e4c6a17c: note: pointer points here 00 00 00 00 cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ^ SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/win/getaddrinfo.c:157:23 in ``` * win: fix pipe.c ubsan failure Changes "random" representation from pointer to number. Fixes: ``` src/win/pipe.c:234:11: runtime error: applying non-zero offset to non-null pointer 0xffffffffffffffff produced null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/win/pipe.c:234:11 in ``` * unix: fix stream.c ubsan failure Avoids performing pointer arithmetic on null pointer. Fixes: ``` src/unix/stream.c:701:15: runtime error: applying zero offset to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/runner/work/libuv/libuv/src/unix/stream.c:701:15 in ```
215 lines
8.0 KiB
C
215 lines
8.0 KiB
C
/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#ifndef UV_WIN_REQ_INL_H_
|
|
#define UV_WIN_REQ_INL_H_
|
|
|
|
#include <assert.h>
|
|
|
|
#include "uv.h"
|
|
#include "internal.h"
|
|
|
|
|
|
#define SET_REQ_STATUS(req, status) \
|
|
(req)->u.io.overlapped.Internal = (ULONG_PTR) (status)
|
|
|
|
#define SET_REQ_ERROR(req, error) \
|
|
SET_REQ_STATUS((req), NTSTATUS_FROM_WIN32((error)))
|
|
|
|
/* Note: used open-coded in UV_REQ_INIT() because of a circular dependency
|
|
* between src/uv-common.h and src/win/internal.h.
|
|
*/
|
|
#define SET_REQ_SUCCESS(req) \
|
|
SET_REQ_STATUS((req), STATUS_SUCCESS)
|
|
|
|
#define GET_REQ_STATUS(req) \
|
|
((NTSTATUS) (req)->u.io.overlapped.Internal)
|
|
|
|
#define REQ_SUCCESS(req) \
|
|
(NT_SUCCESS(GET_REQ_STATUS((req))))
|
|
|
|
#define GET_REQ_ERROR(req) \
|
|
(pRtlNtStatusToDosError(GET_REQ_STATUS((req))))
|
|
|
|
#define GET_REQ_SOCK_ERROR(req) \
|
|
(uv__ntstatus_to_winsock_error(GET_REQ_STATUS((req))))
|
|
|
|
|
|
#define REGISTER_HANDLE_REQ(loop, handle) \
|
|
do { \
|
|
INCREASE_ACTIVE_COUNT((loop), (handle)); \
|
|
uv__req_register((loop)); \
|
|
} while (0)
|
|
|
|
#define UNREGISTER_HANDLE_REQ(loop, handle) \
|
|
do { \
|
|
DECREASE_ACTIVE_COUNT((loop), (handle)); \
|
|
uv__req_unregister((loop)); \
|
|
} while (0)
|
|
|
|
|
|
#define UV_SUCCEEDED_WITHOUT_IOCP(result) \
|
|
((result) && (handle->flags & UV_HANDLE_SYNC_BYPASS_IOCP))
|
|
|
|
#define UV_SUCCEEDED_WITH_IOCP(result) \
|
|
((result) || (GetLastError() == ERROR_IO_PENDING))
|
|
|
|
|
|
#define POST_COMPLETION_FOR_REQ(loop, req) \
|
|
if (!PostQueuedCompletionStatus((loop)->iocp, \
|
|
0, \
|
|
0, \
|
|
&((req)->u.io.overlapped))) { \
|
|
uv_fatal_error(GetLastError(), "PostQueuedCompletionStatus"); \
|
|
}
|
|
|
|
|
|
INLINE static uv_req_t* uv__overlapped_to_req(OVERLAPPED* overlapped) {
|
|
return container_of(overlapped, uv_req_t, u.io.overlapped);
|
|
}
|
|
|
|
|
|
INLINE static void uv__insert_pending_req(uv_loop_t* loop, uv_req_t* req) {
|
|
req->next_req = NULL;
|
|
if (loop->pending_reqs_tail) {
|
|
#ifdef _DEBUG
|
|
/* Ensure the request is not already in the queue, or the queue
|
|
* will get corrupted.
|
|
*/
|
|
uv_req_t* current = loop->pending_reqs_tail;
|
|
do {
|
|
assert(req != current);
|
|
current = current->next_req;
|
|
} while(current != loop->pending_reqs_tail);
|
|
#endif
|
|
|
|
req->next_req = loop->pending_reqs_tail->next_req;
|
|
loop->pending_reqs_tail->next_req = req;
|
|
loop->pending_reqs_tail = req;
|
|
} else {
|
|
req->next_req = req;
|
|
loop->pending_reqs_tail = req;
|
|
}
|
|
}
|
|
|
|
|
|
#define DELEGATE_STREAM_REQ(loop, req, method, handle_at) \
|
|
do { \
|
|
switch (((uv_handle_t*) (req)->handle_at)->type) { \
|
|
case UV_TCP: \
|
|
uv__process_tcp_##method##_req(loop, \
|
|
(uv_tcp_t*) ((req)->handle_at), \
|
|
req); \
|
|
break; \
|
|
\
|
|
case UV_NAMED_PIPE: \
|
|
uv__process_pipe_##method##_req(loop, \
|
|
(uv_pipe_t*) ((req)->handle_at), \
|
|
req); \
|
|
break; \
|
|
\
|
|
case UV_TTY: \
|
|
uv__process_tty_##method##_req(loop, \
|
|
(uv_tty_t*) ((req)->handle_at), \
|
|
req); \
|
|
break; \
|
|
\
|
|
default: \
|
|
assert(0); \
|
|
} \
|
|
} while (0)
|
|
|
|
|
|
INLINE static void uv__process_reqs(uv_loop_t* loop) {
|
|
uv_req_t* req;
|
|
uv_req_t* first;
|
|
uv_req_t* next;
|
|
|
|
if (loop->pending_reqs_tail == NULL)
|
|
return;
|
|
|
|
first = loop->pending_reqs_tail->next_req;
|
|
next = first;
|
|
loop->pending_reqs_tail = NULL;
|
|
|
|
while (next != NULL) {
|
|
req = next;
|
|
next = req->next_req != first ? req->next_req : NULL;
|
|
|
|
switch (req->type) {
|
|
case UV_READ:
|
|
DELEGATE_STREAM_REQ(loop, req, read, data);
|
|
break;
|
|
|
|
case UV_WRITE:
|
|
DELEGATE_STREAM_REQ(loop, (uv_write_t*) req, write, handle);
|
|
break;
|
|
|
|
case UV_ACCEPT:
|
|
DELEGATE_STREAM_REQ(loop, req, accept, data);
|
|
break;
|
|
|
|
case UV_CONNECT:
|
|
DELEGATE_STREAM_REQ(loop, (uv_connect_t*) req, connect, handle);
|
|
break;
|
|
|
|
case UV_SHUTDOWN:
|
|
DELEGATE_STREAM_REQ(loop, (uv_shutdown_t*) req, shutdown, handle);
|
|
break;
|
|
|
|
case UV_UDP_RECV:
|
|
uv__process_udp_recv_req(loop, (uv_udp_t*) req->data, req);
|
|
break;
|
|
|
|
case UV_UDP_SEND:
|
|
uv__process_udp_send_req(loop,
|
|
((uv_udp_send_t*) req)->handle,
|
|
(uv_udp_send_t*) req);
|
|
break;
|
|
|
|
case UV_WAKEUP:
|
|
uv__process_async_wakeup_req(loop, (uv_async_t*) req->data, req);
|
|
break;
|
|
|
|
case UV_SIGNAL_REQ:
|
|
uv__process_signal_req(loop, (uv_signal_t*) req->data, req);
|
|
break;
|
|
|
|
case UV_POLL_REQ:
|
|
uv__process_poll_req(loop, (uv_poll_t*) req->data, req);
|
|
break;
|
|
|
|
case UV_PROCESS_EXIT:
|
|
uv__process_proc_exit(loop, (uv_process_t*) req->data);
|
|
break;
|
|
|
|
case UV_FS_EVENT_REQ:
|
|
uv__process_fs_event_req(loop, req, (uv_fs_event_t*) req->data);
|
|
break;
|
|
|
|
default:
|
|
assert(0);
|
|
}
|
|
}
|
|
}
|
|
|
|
#endif /* UV_WIN_REQ_INL_H_ */
|