885b1ecda0
Passing a buffer that was too small to hold the result made it fail with UV_EPERM because the -1 status code from _NSGetExecutablePath() was returned unmodified to the caller. This commit rewrites uv_exepath() to: 1. Not allocate heap memory, and 2. Not clobber the result buffer on error, and 3. Handle _NSGetExecutablePath()'s and realpath()'s idiosyncracies, and 4. Store as much of the path in the output buffer as possible, don't fail with an error. Makes it behave the same as other platforms. The result is always zero-terminated. Fixes: https://github.com/libuv/libuv/issues/103 PR-URL: https://github.com/libuv/libuv/pull/104 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
78 lines
2.4 KiB
C
78 lines
2.4 KiB
C
/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "uv.h"
|
|
#include "task.h"
|
|
#include <string.h>
|
|
|
|
#define PATHMAX 1024
|
|
extern char executable_path[];
|
|
|
|
TEST_IMPL(get_currentexe) {
|
|
char buffer[PATHMAX];
|
|
size_t size;
|
|
char* match;
|
|
char* path;
|
|
int r;
|
|
|
|
size = sizeof(buffer) / sizeof(buffer[0]);
|
|
r = uv_exepath(buffer, &size);
|
|
ASSERT(!r);
|
|
|
|
/* uv_exepath can return an absolute path on darwin, so if the test runner
|
|
* was run with a relative prefix of "./", we need to strip that prefix off
|
|
* executable_path or we'll fail. */
|
|
if (executable_path[0] == '.' && executable_path[1] == '/') {
|
|
path = executable_path + 2;
|
|
} else {
|
|
path = executable_path;
|
|
}
|
|
|
|
match = strstr(buffer, path);
|
|
/* Verify that the path returned from uv_exepath is a subdirectory of
|
|
* executable_path.
|
|
*/
|
|
ASSERT(match && !strcmp(match, path));
|
|
ASSERT(size == strlen(buffer));
|
|
|
|
/* Negative tests */
|
|
size = sizeof(buffer) / sizeof(buffer[0]);
|
|
r = uv_exepath(NULL, &size);
|
|
ASSERT(r == UV_EINVAL);
|
|
|
|
r = uv_exepath(buffer, NULL);
|
|
ASSERT(r == UV_EINVAL);
|
|
|
|
size = 0;
|
|
r = uv_exepath(buffer, &size);
|
|
ASSERT(r == UV_EINVAL);
|
|
|
|
memset(buffer, -1, sizeof(buffer));
|
|
|
|
size = 1;
|
|
r = uv_exepath(buffer, &size);
|
|
ASSERT(r == 0);
|
|
ASSERT(size == 0);
|
|
ASSERT(buffer[0] == '\0');
|
|
|
|
return 0;
|
|
}
|