gre-ilya/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

linux: return early if we have no interfaces

Browse Source 
This was pointed out as possible undefined allocation of 0 bytes by
clang-analyzer. `malloc` of 0 bytes can return either `NULL` or a
valid pointer which can't be dereferenced. On systems which return
`NULL`, we would consider it a `malloc` error and return an `ENOMEM` to
the caller.

PR-URL: https://github.com/libuv/libuv/pull/13
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This commit is contained in:
Maciej Małecki 2014-09-27 00:43:21 +02:00 committed by Ben Noordhuis
parent 18d58643af
commit f86cd02a94
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/unix/linux-core.c
View File

@ -754,6 +754,7 @@ int uv_interface_addresses(uv_interface_address_t** addresses,
return -errno; return -errno;
*count = 0; *count = 0;
*addresses = NULL;
/* Count the number of interfaces */ /* Count the number of interfaces */
for (ent = addrs; ent != NULL; ent = ent->ifa_next) { for (ent = addrs; ent != NULL; ent = ent->ifa_next) {
@ -766,6 +767,9 @@ int uv_interface_addresses(uv_interface_address_t** addresses,
(*count)++; (*count)++;
} }
if (*count == 0)
return 0;
*addresses = malloc(*count * sizeof(**addresses)); *addresses = malloc(*count * sizeof(**addresses));
if (!(*addresses)) if (!(*addresses))
return -ENOMEM; return -ENOMEM;