gre-ilya/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unix: fix uv__signal_loop_cleanup call in init (#4876)

Browse Source 
While unlikely that this fails (since it is implemented to call
`abort()` instead of actually return an error code, we would
theoretically leak this state. The process state init doesn't actually
have a cleanup, and just awkwardly relies on uv_signal_close being
unnecessary (which is likely true though).
This commit is contained in:
Jameson Nash 2025-09-25 11:02:44 -04:00 committed by GitHub
parent 392590a738
commit cfdce92fa5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/unix/loop.c
View File

@ -83,7 +83,7 @@ int uv_loop_init(uv_loop_t* loop) {
uv__signal_global_once_init();
err = uv__process_init(loop);
if (err)
goto fail_signal_init;
goto fail_process_init;
uv__queue_init(&loop->process_handles);
err = uv_rwlock_init(&loop->cloexec_lock);
@ -110,9 +110,8 @@ fail_mutex_init:
uv_rwlock_destroy(&loop->cloexec_lock);
fail_rwlock_init:
fail_process_init:
uv__signal_loop_cleanup(loop);
fail_signal_init:
uv__platform_loop_delete(loop);
if (loop->backend_fd != -1) {