gre-ilya/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: add uv_fs_poll_t immediate file change test

Browse Source 
Test that synchronous file changes right after starting the uv_fs_poll_t
handle are picked up by libuv.

Refs: https://github.com/libuv/libuv/issues/4543
This commit is contained in:
Ben Noordhuis 2025-10-21 13:07:01 +02:00
parent a944c422cc
commit ce28eabc4b
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
test/test-fs-poll.c
View File

@ -56,7 +56,8 @@ static void touch_file(const char* path) {
FILE* fp;
int i;
ASSERT((fp = fopen(FIXTURE, "w+")));
fp = fopen(path, "w+");
ASSERT_NOT_NULL(fp);
/* Need to change the file size because the poller may not pick up
* sub-second mtime changes.
@ -92,6 +93,7 @@ static void poll_cb_noop(uv_fs_poll_t* handle,
int status,
const uv_stat_t* prev,
const uv_stat_t* curr) {
poll_cb_called++;
}
@ -290,3 +292,30 @@ TEST_IMPL(fs_poll_close_request_stop_when_active) {
MAKE_VALGRIND_HAPPY(&loop);
return 0;
}
TEST_IMPL(fs_poll_immediate_change) {
uv_fs_poll_t poll_handle;
uv_loop_t loop;
remove(FIXTURE);
touch_file(FIXTURE);
ASSERT_OK(uv_loop_init(&loop));
ASSERT_OK(uv_fs_poll_init(&loop, &poll_handle));
ASSERT_OK(uv_fs_poll_start(&poll_handle, poll_cb_noop, FIXTURE, 100));
touch_file(FIXTURE);
/* Having to call uv_run(UV_RUN_ONCE) thrice is a bug:
* it's the implementation detail leaking out that uv_fs_poll_t
* internally uses a uv_timer_t and a uv_fs_t to poll the path.
* See https://github.com/libuv/libuv/issues/4543
*/
uv_run(&loop, UV_RUN_ONCE);
uv_run(&loop, UV_RUN_ONCE);
uv_run(&loop, UV_RUN_ONCE);
ASSERT_EQ(1, poll_cb_called);
uv_close((uv_handle_t*) &poll_handle, close_cb);
uv_run(&loop, UV_RUN_DEFAULT);
ASSERT_EQ(1, close_cb_called);
MAKE_VALGRIND_HAPPY(&loop);
remove(FIXTURE);
return 0;
}

2
test/test-list.h
View File

@ -352,6 +352,7 @@ TEST_DECLARE (fs_poll_close_request)
TEST_DECLARE (fs_poll_close_request_multi_start_stop)
TEST_DECLARE (fs_poll_close_request_multi_stop_start)
TEST_DECLARE (fs_poll_close_request_stop_when_active)
TEST_DECLARE (fs_poll_immediate_change)
TEST_DECLARE (kill)
TEST_DECLARE (kill_invalid_signum)
TEST_DECLARE (fs_file_noent)
@ -1037,6 +1038,7 @@ TASK_LIST_START
TEST_ENTRY (fs_poll_close_request_multi_start_stop)
TEST_ENTRY (fs_poll_close_request_multi_stop_start)
TEST_ENTRY (fs_poll_close_request_stop_when_active)
TEST_ENTRY (fs_poll_immediate_change)
TEST_ENTRY (kill)
TEST_ENTRY (kill_invalid_signum)