gre-ilya/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Persist and lazily initialize ResizePseudoConsole func

Browse Source 
Both GetProcAddress as well as LoadLibrary are fairly expensive. So cache
the result. This is racy, but it doesn't matter much, on a collision we'll
do a bit of throw away work, but the assignment of `pfnResize` is atomic.
So nothing bad will happen.
This commit is contained in:
Patrick Böker 2026-01-03 23:44:50 +01:00
parent 29bb0afef2
commit a1008b1f6a
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/win/process.c
View File

@ -935,20 +935,25 @@ void uv__process_endgame(uv_loop_t* loop, uv_process_t* handle) {
int uv_pty_resize(uv_process_t* process,
unsigned short cols,
unsigned short rows) {
static PFNRESIZEPSEUDOCONSOLE pfnResize = NULL;
if (process->pty_handle == NULL)
return UV_EINVAL;
HANDLE hLibrary = LoadLibraryExW(L"kernel32.dll", 0, 0);
// Error loading kernel32.dll: (error code %i)
if (!hLibrary)
return uv_translate_sys_error(GetLastError());
PFNRESIZEPSEUDOCONSOLE pfnResize = (PFNRESIZEPSEUDOCONSOLE)GetProcAddress((HMODULE)hLibrary,"ResizePseudoConsole");
if (!pfnResize) {
int err = GetLastError();
if (err == ERROR_PROC_NOT_FOUND)
return UV_ENOTSUP;
else
return uv_translate_sys_error(err);
if (pfnResize == NULL) {
HANDLE hLibrary = LoadLibraryExW(L"kernel32.dll", 0, 0);
// Error loading kernel32.dll: (error code %i)
if (!hLibrary)
return uv_translate_sys_error(GetLastError());
pfnResize = (PFNRESIZEPSEUDOCONSOLE)GetProcAddress((HMODULE)hLibrary,"ResizePseudoConsole");
if (!pfnResize) {
int err = GetLastError();
if (err == ERROR_PROC_NOT_FOUND)
return UV_ENOTSUP;
else
return uv_translate_sys_error(err);
}
}
COORD size = {cols, rows};