diff --git a/Makefile.am b/Makefile.am index bd54e45dd..7d3dfa054 100644 --- a/Makefile.am +++ b/Makefile.am @@ -114,6 +114,7 @@ test_run_tests_SOURCES = test/blackhole-server.c \ test/test-barrier.c \ test/test-callback-order.c \ test/test-callback-stack.c \ + test/test-close-order.c \ test/test-condvar.c \ test/test-connection-fail.c \ test/test-cwd-and-chdir.c \ diff --git a/src/win/core.c b/src/win/core.c index 16373da79..640e9eec6 100644 --- a/src/win/core.c +++ b/src/win/core.c @@ -281,10 +281,7 @@ int uv_run(uv_loop_t *loop, uv_run_mode mode) { uv_process_timers(loop); uv_process_reqs(loop); - uv_process_endgames(loop); - uv_idle_invoke(loop); - uv_prepare_invoke(loop); (*poll)(loop, loop->idle_handles == NULL && @@ -296,6 +293,7 @@ int uv_run(uv_loop_t *loop, uv_run_mode mode) { !(mode & UV_RUN_NOWAIT)); uv_check_invoke(loop); + uv_process_endgames(loop); if (mode == UV_RUN_ONCE) { /* UV_RUN_ONCE implies forward progess: at least one callback must have diff --git a/test/test-close-order.c b/test/test-close-order.c new file mode 100644 index 000000000..e2f25f987 --- /dev/null +++ b/test/test-close-order.c @@ -0,0 +1,80 @@ +/* Copyright Joyent, Inc. and other Node contributors. All rights reserved. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +#include "uv.h" +#include "task.h" + +static int check_cb_called; +static int timer_cb_called; +static int close_cb_called; + +static uv_check_t check_handle; +static uv_timer_t timer_handle1; +static uv_timer_t timer_handle2; + + +static void close_cb(uv_handle_t* handle) { + ASSERT(handle != NULL); + close_cb_called++; +} + + +/* check_cb should run before any close_cb */ +static void check_cb(uv_check_t* handle, int status) { + ASSERT(check_cb_called == 0); + ASSERT(timer_cb_called == 1); + ASSERT(close_cb_called == 0); + uv_close((uv_handle_t*) handle, close_cb); + uv_close((uv_handle_t*) &timer_handle2, close_cb); + check_cb_called++; +} + + +static void timer_cb(uv_timer_t* handle, int status) { + uv_close((uv_handle_t*) handle, close_cb); + timer_cb_called++; +} + + +TEST_IMPL(close_order) { + uv_loop_t* loop; + loop = uv_default_loop(); + + uv_check_init(loop, &check_handle); + uv_check_start(&check_handle, check_cb); + uv_timer_init(loop, &timer_handle1); + uv_timer_start(&timer_handle1, timer_cb, 0, 0); + uv_timer_init(loop, &timer_handle2); + uv_timer_start(&timer_handle2, timer_cb, 100000, 0); + + ASSERT(check_cb_called == 0); + ASSERT(close_cb_called == 0); + ASSERT(timer_cb_called == 0); + + uv_run(loop, UV_RUN_DEFAULT); + + ASSERT(check_cb_called == 1); + ASSERT(close_cb_called == 3); + ASSERT(timer_cb_called == 1); + + MAKE_VALGRIND_HAPPY(); + return 0; +} diff --git a/test/test-list.h b/test/test-list.h index 334b48322..5f8efda6e 100644 --- a/test/test-list.h +++ b/test/test-list.h @@ -21,6 +21,7 @@ TEST_DECLARE (platform_output) TEST_DECLARE (callback_order) +TEST_DECLARE (close_order) TEST_DECLARE (run_once) TEST_DECLARE (run_nowait) TEST_DECLARE (loop_stop) @@ -242,6 +243,7 @@ TASK_LIST_START #if 0 TEST_ENTRY (callback_order) #endif + TEST_ENTRY (close_order) TEST_ENTRY (run_once) TEST_ENTRY (run_nowait) TEST_ENTRY (loop_stop) diff --git a/uv.gyp b/uv.gyp index 3c662438b..1c7f0f596 100644 --- a/uv.gyp +++ b/uv.gyp @@ -297,6 +297,7 @@ 'test/test-async-null-cb.c', 'test/test-callback-stack.c', 'test/test-callback-order.c', + 'test/test-close-order.c', 'test/test-connection-fail.c', 'test/test-cwd-and-chdir.c', 'test/test-delayed-accept.c',