gre-ilya/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unix: check return value of fcntl call (#5089)

Browse Source 
The fcntl cannot fail at this point but let's check the return code
anyway, just in case.

Fixes: https://github.com/libuv/libuv/issues/5080
This commit is contained in:
Ben Noordhuis 2026-03-21 13:18:13 +01:00 committed by GitHub
parent 58418d5310
commit 1f56978a28
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/unix/process.c
View File

@ -292,6 +292,7 @@ static void uv__process_child_init(const uv_process_options_t* options,
sigset_t signewset; sigset_t signewset;
int close_fd; int close_fd;
int use_fd; int use_fd;
int err;
int fd; int fd;
int n; int n;
@ -334,9 +335,9 @@ static void uv__process_child_init(const uv_process_options_t* options,
if (pipes[fd][1] == -1) if (pipes[fd][1] == -1)
uv__write_errno(error_fd); uv__write_errno(error_fd);
#ifndef F_DUPFD_CLOEXEC /* POSIX 2008 */ #ifndef F_DUPFD_CLOEXEC /* POSIX 2008 */
n = uv__cloexec(pipes[fd][1], 1); err = uv__cloexec(pipes[fd][1], 1);
if (n) if (err)
uv__write_int(error_fd, n); uv__write_int(error_fd, err);
#endif #endif
} }
@ -361,9 +362,9 @@ static void uv__process_child_init(const uv_process_options_t* options,
if (fd == use_fd) { if (fd == use_fd) {
if (close_fd == -1) { if (close_fd == -1) {
n = uv__cloexec(use_fd, 0); err = uv__cloexec(use_fd, 0);
if (n) if (err)
uv__write_int(error_fd, n); uv__write_int(error_fd, err);
} }
} }
else { else {
@ -373,8 +374,11 @@ static void uv__process_child_init(const uv_process_options_t* options,
if (fd == -1) if (fd == -1)
uv__write_errno(error_fd); uv__write_errno(error_fd);
if (fd <= 2 && close_fd == -1) if (fd <= 2 && close_fd == -1) {
uv__nonblock_fcntl(fd, 0); err = uv__nonblock_fcntl(fd, 0);
if (err)
uv__write_int(error_fd, err);
}
if (close_fd >= stdio_count) if (close_fd >= stdio_count)
uv__close(close_fd); uv__close(close_fd);