From 196eb8b94f7c5543e9057cac7a417fa5c0c5b8af Mon Sep 17 00:00:00 2001 From: Keane Date: Fri, 14 Apr 2017 14:42:44 -0700 Subject: [PATCH] win: remove __declspec(inline) from atomic op __declspec(inline) is completely undocumented, as well as unnecessary. The INLINE preprocessor macro is used throughout libuv, so this simply replaces the only instance of declspec(inline) with the macro version. PR-URL: https://github.com/libuv/libuv/pull/1307 Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig --- src/win/atomicops-inl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/win/atomicops-inl.h b/src/win/atomicops-inl.h index 61e006026..6d8126f69 100644 --- a/src/win/atomicops-inl.h +++ b/src/win/atomicops-inl.h @@ -23,6 +23,7 @@ #define UV_WIN_ATOMICOPS_INL_H_ #include "uv.h" +#include "internal.h" /* Atomic set operation on char */ @@ -34,7 +35,7 @@ /* target to be aligned. */ #pragma intrinsic(_InterlockedOr8) -static char __declspec(inline) uv__atomic_exchange_set(char volatile* target) { +static char INLINE uv__atomic_exchange_set(char volatile* target) { return _InterlockedOr8(target, 1); }