gre-ilya/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

win: decrease GetFinalPathNameByHandleW calls

Browse Source
This commit is contained in:
StefanStojanovic 2026-03-17 16:45:54 +01:00
parent b0a0df039b
commit 0a121575ca
1 changed files with 22 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/win/fs-event.c
View File

@ -433,6 +433,7 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,
WCHAR* filenamew = NULL;
WCHAR* long_filenamew = NULL;
DWORD offset = 0;
int dir_event_detected = 0;
assert(req->type == UV_FS_EVENT_REQ);
assert(handle->req_pending);
@ -459,6 +460,10 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,
assert(!filenamew);
assert(!long_filenamew);
if (file_info->FileNameLength == 0) {
dir_event_detected = 1;
}
/*
* Fire the event only if we were asked to watch a directory,
* or if the filename filter matches.
@ -587,6 +592,7 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,
sizeof(info)) &&
info.Directory &&
info.DeletePending) {
dir_event_detected = 1;
uv__convert_utf16_to_utf8(handle->dirw, -1, &filename);
handle->cb(handle, filename, UV_RENAME, 0);
uv__free(filename);
@ -600,22 +606,25 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,
uv__want_endgame(loop, (uv_handle_t*)handle);
} else if (uv__is_active(handle)) {
/*
* Check if the handle has become a zombie pointing to $Extend\$Deleted.
* If so, report as deleted and don't re-queue.
* Check if the handle has become a zombie pointing to \$Extend\$Deleted\.
* Only perform the check if we detected an event on the directory, which
* may indicate deletion.
*/
WCHAR path_buf[MAX_PATH];
DWORD path_len = GetFinalPathNameByHandleW(handle->dir_handle,
path_buf,
ARRAY_SIZE(path_buf),
FILE_NAME_NORMALIZED);
if (path_len > 0 && path_len < MAX_PATH) {
if (wcsstr(path_buf, L"\\$Extend\\$Deleted\\") != NULL) {
handle->cb(handle, NULL, 0, UV_ENOENT);
return;
if (dir_event_detected) {
WCHAR path_buf[MAX_PATH];
DWORD path_len = GetFinalPathNameByHandleW(handle->dir_handle,
path_buf,
ARRAY_SIZE(path_buf),
FILE_NAME_NORMALIZED);
if (path_len > 0 && path_len < MAX_PATH) {
if (wcsstr(path_buf, L"\\$Extend\\$Deleted\\") != NULL) {
handle->cb(handle, NULL, 0, UV_ENOENT);
return;
}
}
}
uv__fs_event_queue_readdirchanges(loop, handle);
}
}