PR #203 "Multithread fix for PNG loading" includes a suggested fix
that moves the variable fp to the Fl_PNG_Image structure.
This commit fixes the threading issue by allocating the variable fp
with new, avoiding the [-Wclobbered] warning w/o using a static var.
The same issue is now also fixed in Fl_JPEG_Image.
- remove obsolete svn '$Id$' tags from all source files
- update .fl files and generated files accordingly
- replace 'http://www.fltk.org' URL's with 'https://...'
- replace bug report URL 'str.php' with 'bugs.php'
- remove trailing whitespace
- fix other whitespace errors flagged by Git
- add and/or fix missing or wrong standard headers
- convert tabs to spaces in all source files
The only relevant code changes are in the fluid/ folder where
some .fl files and other source files were used to generate
the '$Id' headers and footers.
Compilation with gcc -Wall -Wextra displayed the following warning:
Fl_PNG_Image.cxx: In member function ‘void Fl_PNG_Image::load_png_(const char*, const unsigned char*, int)’:
Fl_PNG_Image.cxx:118:9: warning: variable ‘fp’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered]
Making the variable static and initializing it properly avoids this
potential error in the PNG lib's error handling.
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.4@12439 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
Fl_PNG_Image.cxx:108: warning: 'fp' may be used uninitialized in this function
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.3@8290 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
This constructor has a 3rd argument, the size of the array holding the in-memory PNG image.
This allows the constructor to check for errors in the image.
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.3@8287 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
fluid/Fl_Type.h:
- Added read_image() declaration to Fl_Window_Type class.
fluid/Fl_Window_Type.cxx:
- Added Overlay_Window::read_image() and
Fl_Window_Type::read_image() functions.
- Fl_Window_Type::fix_overlay(): update menu indices.
- toggle_overlays(): update menu indices.
fluid/fluid.cxx:
- save_template_cb(): Added to save to
~/.fltk/fltk.org/fluid/templates, along with PNG screenshot
of first window.
- "Save To" instead of "Save to".
- Use fl_alert() for errors, not fl_message().
- Add "File/Save Template..." and "File/Print..." (not yet
implemented) menu items.
- toggle_widgetbin_cb(): update menu indices.
fluid/undo.cxx:
- Update menu item indices.
- Don't need extra slash in undo checkpoint filename.
src/Fl_PNG_Image.cxx:
- Fix typo in #endif comment.
src/Fl_Window.cxx:
- Fl_Window::draw(): save/restore flags() when changing label.
- Fl_Window::iconlabel(): save/restore flags() when changing label.
src/fl_rect.cxx:
- fl_not_clipped(): don't use current window for gross clipping.
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.1@4147 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
Added DESTDIR support and now remove all man pages for the
"uninstall" target (STR #545)
Fix PNG drawing on buggy WIN32 graphics cards (STR #548)
The configure script didn't propagate the CPPFLAGS environment
variable (STR #549)
The numpad keys didn't work properly on WIN32 (STR #502)
fl_input() and friends now set the input focus to the text field
when the dialog is shown (STR #553)
Fixed background color mixup when drawing Fl_Choice menus (STR
#544)
Fixed MingW makefiles (STR #550)
More VC++ project file tweaking (STR #559)
Fl_PNG_Image didn't use the png_set_trns_to_alpha function when
available (STR #547)
The FL_UNFOCUS event wasn't always sent when switching tabs (STR
#558)
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.1@3868 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
libraries don't exit the app with a bad file (STR #168)
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.1@3105 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
Don't use png_read_destroy() - it doesn't free all memory.
Add uncache() method to image classes.
Memory/initialization bugs in Fl_File_Chooser (valgrind)
Make sure both Fl_Window constructors have default cursor initialization
code...
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.1@2562 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
classes: new copy(), copy(w,h), desaturate(), color_average(), and
inactive() methods, alloc_xyz member for copied data, etc.
Updated test programs to use inactive() and copy() methods to create
inactive images for the test buttons, plus the inactive button to toggle
it...
Added start of separate image classes, a la 2.0, for various image formats.
FLUID will also be updated for it...
git-svn-id: file:///fltk/svn/fltk/branches/branch-1.1@1703 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
