gre-ilya/fltk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Text positioning different in 1.4.x vs 1.3.x (#568) - cont'd

Browse Source 
@wcout reports that we get better results if function pango_font_metrics_get_height()
is not used until version 1.50.6 and above of libpango. The difference is specially visible
with underscore characters in unscaled, standard DPI displays. This commit does that.
This commit is contained in:
ManoloFLTK 2022-12-10 19:00:09 +01:00
parent 234a33c12f
commit 8dcd121d44
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/drivers/Cairo/Fl_Cairo_Graphics_Driver.cxx
View File

@ -1135,7 +1135,15 @@ Fl_Cairo_Font_Descriptor::Fl_Cairo_Font_Descriptor(const char* name, Fl_Fontsize
PangoFontMetrics *metrics = pango_fontset_get_metrics(fontset);
ascent = pango_font_metrics_get_ascent(metrics);
descent = pango_font_metrics_get_descent(metrics);
#if PANGO_VERSION_CHECK(1,44,0)
/* Function pango_font_metrics_get_height() giving the line height of a pango font
appears with pango version 1.44. However, with pango version 1.48.10 and below,
this function gives values that make the underscore invisible on lowdpi display
and at 100% scaling (the underscore becomes visible starting at 120% scaling).
With pango version 1.50.6 (Ubuntu 22.04) this problem disappears.
Consequently, function pango_font_metrics_get_height() is not used until version 1.50.6
*/
//#if PANGO_VERSION_CHECK(1,44,0)
#if PANGO_VERSION_CHECK(1,50,6)
line_height = pango_font_metrics_get_height(metrics); // 1.44
#else
line_height = (pango_font_metrics_get_ascent(metrics) + pango_font_metrics_get_descent(metrics)) * 1.025 + 0.5;